Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added services to set tool voltage and zero force torque sensor - galactic backport (#466) #707

Closed

Conversation

srsidd
Copy link

@srsidd srsidd commented Jun 5, 2023

Added launch arguments for reverse ip and script command interface port.
Tested with hardware (UR5) and worked without error when set in remote control mode.

Backport to galactic. Goes with UniversalRobots/Universal_Robots_ROS2_Description#73.

…ersalRobots#466)

Added launch arguments for reverse ip and script command interface port.
@srsidd srsidd changed the title Added services to set tool voltage and zero force torque sensor (#466) Added services to set tool voltage and zero force torque sensor - galactic backport (#466) Jun 6, 2023
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing this. I guess, you are aware, that galactic is EOL since a while, hence there won't be any support on this, anymore. However, since you took the effort of porting this and from a quick glance this seems fine, I would be merging this anyway. However, as noted, I think the additional launchfile should be removed.


Edit: Now seeing that there is an accompanying MR on the description, I am against putting that effort into galactic. I would rather suggest switching to Humble.

@@ -0,0 +1,560 @@
# Copyright (c) 2021 PickNik, Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have launchfiles in ur_robot_driver on galactic, I guess it doesn't make much sense to add this here.

@fmauch
Copy link
Collaborator

fmauch commented Nov 15, 2023

Closing this as galactic has been EOL for quite some time now.

@fmauch fmauch closed this Nov 15, 2023
@srsidd srsidd deleted the backport-zero-force-torque branch November 20, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants